transform_file task uses ack_late=True #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenGalewsky
force-pushed
the
task_ack
branch
2 times, most recently
from
dd5bc89
to
352d76b
Compare
ponyisi
reviewed
Oct 15, 2024
transformer_sidecar/src/transformer_sidecar/object_store_uploader.py
Outdated
Show resolved
Hide resolved
We found that when the autoscaler decides to scale down the number of transformers that the science image dies immediatly which causes the "sync" call to fail. When this happens we need to put the transform request back onto rabbit queue and die gracefully. Add the acks_late propoerty to the transform_file request and now the failure to receive the sync command from the science container is a fatal error.
1. Add a no-op SIGTERM handler to the object store uploader so it doesn't terminate when the pod shuts down. It stays up and relies on the main Celery worker to send the poison pill to the queue when it is time to go. 2. Set the celery pre-fetch multiplier to one so we don't get greedy and grab more transform requests than we can digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that when the autoscaler decides to scale down the number of transformers that the science image dies immediatly which causes the "sync" call to fail. When this happens we need to put the transform request back onto rabbit queue and die gracefully.
Add the acks_late propoerty to the transform_file request and now the failure to receive the sync command from the science container is a fatal error.